Skip to content

Make description of step more accurate#1108

Merged
lucascosti merged 6 commits intogithub:mainfrom
Deborah-Digges:patch-3
Nov 16, 2020
Merged

Make description of step more accurate#1108
lucascosti merged 6 commits intogithub:mainfrom
Deborah-Digges:patch-3

Conversation

@Deborah-Digges
Copy link
Copy Markdown
Member

@Deborah-Digges Deborah-Digges commented Nov 6, 2020

Why:

While learning about GitHub actions, I found it difficult to visualize the hierarchy of the various components.

Workflows -> Jobs -> Steps -> Commands (Actions or bash commands)

I find it important to mention early on that the leaf nodes of these workflow don't have to be actions, but could also be a bash command.

What's being changed:

Check off the following:

Comment thread content/actions/learn-github-actions/introduction-to-github-actions.md Outdated
…tions.md

Co-authored-by: Nick Schonning <nschonni@gmail.com>
@janiceilene
Copy link
Copy Markdown
Contributor

Thanks so much for opening a PR @Deborah-Digges! I'll get this triaged for review 🎉

@janiceilene janiceilene added actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team ecosystem This issue or pull request should be reviewed by the Docs Ecosystem team labels Nov 6, 2020
@github-actions
Copy link
Copy Markdown
Contributor

This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit.

@github-actions github-actions Bot added the stale There is no recent activity on this issue or pull request label Nov 14, 2020
@Deborah-Digges
Copy link
Copy Markdown
Member Author

Commenting to prevent the stale action from closing this

@github-actions github-actions Bot removed the stale There is no recent activity on this issue or pull request label Nov 15, 2020
@lucascosti lucascosti self-assigned this Nov 16, 2020
Copy link
Copy Markdown
Contributor

@lucascosti lucascosti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for these improvements, @Deborah-Digges! 🙇‍♂️

I'll make a few tiny edits and get this merged in 🚀

Comment thread content/actions/learn-github-actions/introduction-to-github-actions.md Outdated
#### Runners

A runner is a server that has the {% data variables.product.prodname_actions %} runner application installed. You can use a runner hosted by {% data variables.product.prodname_dotcom %}, or you can host your own. A runner listens for available jobs, runs one job at a time, and reports the progress, logs, and results back to {% data variables.product.prodname_dotcom %}. For {% data variables.product.prodname_dotcom %}-hosted runners, each job in a workflow runs in a fresh virtual environment.
A runner is a server that has the [{% data variables.product.prodname_actions %} runner application](https://github.com/actions/runner) installed. You can use a runner hosted by {% data variables.product.prodname_dotcom %}, or you can host your own. A runner listens for available jobs, runs one job at a time, and reports the progress, logs, and results back to {% data variables.product.prodname_dotcom %}. For {% data variables.product.prodname_dotcom %}-hosted runners, each job in a workflow runs in a fresh virtual environment.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the link here! 👍

Comment thread content/actions/learn-github-actions/introduction-to-github-actions.md Outdated
@lucascosti lucascosti merged commit 8f08c3b into github:main Nov 16, 2020
@github-actions
Copy link
Copy Markdown
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours.

jnidzwetzki pushed a commit to jnidzwetzki/docs that referenced this pull request Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team ecosystem This issue or pull request should be reviewed by the Docs Ecosystem team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants